Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place null algos in separate functions per #29 #30

Closed
dmcglinn opened this issue Jul 10, 2016 · 2 comments
Closed

Place null algos in separate functions per #29 #30

dmcglinn opened this issue Jul 10, 2016 · 2 comments

Comments

@dmcglinn
Copy link
Member

We should break the three null model algos out as separate functions rather than just nestled within the get_delta_stats function. My reasons are 1) it will be easier to write a function for generating the null results for rarefied S only and not delta S which will need the same shuffling algos, 2) it makes it easier for other scientists to jump right to the important part (the null algos) and see how they work in a simple transparent way.

@rueuntal rueuntal mentioned this issue Jul 10, 2016
57 tasks
@rueuntal
Copy link
Contributor

Totally agreed. But the structural changes are probably not trivial, so I'm inclined to postpone it until we are sure that the function in its current setting is running properly. What do you think?

@rueuntal
Copy link
Contributor

Fixed per #77 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants