Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 Page. #53

Open
rpigu-i opened this issue Oct 4, 2018 · 2 comments
Open

404 Page. #53

rpigu-i opened this issue Oct 4, 2018 · 2 comments
Labels
MVP2 MVP2 tasks
Milestone
v2 (MVP2)

Comments

@rpigu-i
Copy link
Collaborator

rpigu-i commented Oct 4, 2018

Now we handle 403 via the Lambda function, we need to ensure when a redirect doesn't exist we display a 404 message.
@rpigu-i
Copy link
Collaborator Author

rpigu-i commented Oct 4, 2018

We should also test this does not interfere with the work @grgur is working on to handle subsection of the site that need to implement auth

@grgur
Copy link
Member

grgur commented Oct 5, 2018

ATM I scoped authentication to the /private route

@rpigu-i rpigu-i changed the title 404 Page. MVP2 - 404 Page. Oct 11, 2018
@rpigu-i rpigu-i added the MVP2 MVP2 tasks label Oct 22, 2019
@rpigu-i rpigu-i changed the title MVP2 - 404 Page. 404 Page. Oct 22, 2019
@rpigu-i rpigu-i added this to the v2 (MVP2) milestone Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MVP2 MVP2 tasks
Projects
None yet
Milestone
v2 (MVP2)
Development

No branches or pull requests
2 participants
@grgur @rpigu-i