Add missing AWS::Lambda::Function parameters #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds missing parameters for AWS::Lambda::Permission and AWS::Lambda::Alias as well as documentation.
seanmcl
reviewed
Dec 14, 2017
| } | ||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
||
| /** | ||
| * The AWS::Lambda::Function resource creates an AWS Lambda (Lambda) function that can run code in response to events. |
There was a problem hiding this comment.
Are these comments helpful? I find docs get quickly out of date, and always consult the original docs anyway for any arguments.
There was a problem hiding this comment.
Yeah, it's not a perfect situation. I've found it occasionally helpful for the TheThing: Token[String] type parameters to see if it wants an ARN or a name, for example, without needing to swap to my browser and look it up.
This was referenced Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
Also adds missing parameters for AWS::Lambda::Permission and AWS::Lambda::Alias as well as documentation.