Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active shift/alt prevents going to meta layers if no meta#-shift/alt is defined #20

Closed
bachp opened this issue Sep 2, 2011 · 5 comments
Labels

Comments

@bachp
Copy link

bachp commented Sep 2, 2011

To reproduce the problem do the following:

We have the following layers defined:
default
default-shift
meta1

If the currently active layout is default-shift and i click on the meta1 the keyboard doesn't do anything. This is due to the fact that it tries to go to meta1-shift which doesn't exist.

The solution to this problem I propose would be to automatically change shift to inactive whenever a meta key is pressed.
What do you think about this approach?

@bachp
Copy link
Author

bachp commented Sep 2, 2011

Is it possible to extend stickyShift so that disables shift on meta key press too? So that if you are on default-shift and click the meta1 key it would always go to meta1 instead of meta1-shift. I think this would be a more consistent behavior for stickyShift=false.

@bachp bachp closed this as completed Sep 2, 2011
@bachp bachp reopened this Sep 2, 2011
@Mottie
Copy link
Owner

Mottie commented Sep 2, 2011

Hi Pascal-bach!

Sure! I like your approach, it sounds more intuitive... I just updated the plugin to version 1.8.13 :)

@bachp
Copy link
Author

bachp commented Sep 5, 2011

Hi Mottie, the switching between meta layers with shift is now working. Thanks.

I however noticed a bug or inconsistency in the new stickyShift handling. When you to a meta layer the shift key gets released. However if you switch back from a meta layer to the default layer the shift key stays.

@Mottie
Copy link
Owner

Mottie commented Sep 6, 2011

Hi Pascal-bach!

Ok, I fixed the problem in the latest update - now 1.8.14. Hopefully with the other changes, I didn't introduce any new bugs o.O LOL

@Mottie Mottie closed this as completed Sep 9, 2011
@bachp
Copy link
Author

bachp commented Sep 22, 2011

Ok the problem seems fixed now. Thanks again for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants