Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery UI dependency #263

Closed
Aurelain opened this issue Mar 24, 2014 · 5 comments
Closed

jQuery UI dependency #263

Aurelain opened this issue Mar 24, 2014 · 5 comments
Labels

Comments

@Aurelain
Copy link

It would be helpful to achieve independence from jQuery UI.

Currently, on line 258, the following check is performed:

if ($.ui.position) {
    base.$keyboard.position(base.position);
}

This is the only place where $.ui is required.
I propose adding an extra check, like the following:

if ($.ui && $.ui.position) {
    base.$keyboard.position(base.position);
}
@Mottie
Copy link
Owner

Mottie commented Mar 24, 2014

Hi @Aurelain!

Yes, that is a good idea... odd that I never noticed any issues before.

I'll have this added in the next update.

@Mottie Mottie added the Bug label Mar 24, 2014
@liftarn
Copy link

liftarn commented Mar 27, 2014

I did a fiddle at http://jsfiddle.net/liftarn/8qgBK/
Try it with and without checking jQuery UI

@liftarn
Copy link

liftarn commented Mar 27, 2014

Also try http://jsfiddle.net/liftarn/MK947/2018/ with and without jQuery UI and notice that the position of the pop-up is different.

@Aurelain
Copy link
Author

You are right about that. To achieve true independence, some extra code would need to be added.
However, my issue was much more benign: I wanted a more complete "if" clause.

My use-case: I'm taking over the positioning of the keyboard from outside. Thus, for me, jQuery UI is unnecessary. That missing clause forced me to add a dummy "$.ui = {}" :).

@Mottie Mottie closed this as completed in 6a58781 Mar 27, 2014
@Mottie
Copy link
Owner

Mottie commented Nov 20, 2014

Ok, this should be fixed in 1.19.0. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants