Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroying a keyboard while it is visible doesn't fully remove it #337

Closed
patriciavandermeer opened this issue Mar 11, 2015 · 7 comments
Closed
Labels

Comments

@patriciavandermeer
Copy link

First off: Great plugin, thanks for maintaining it!!

I am making a page where the user can choose if they want to show the keyboard for the inputs or not.

Basically, they check a checkbox, it sets the keyboards up, they uncheck it, it removes them.

If they have it checked, and click in the input, it shows the keyboard perfectly, then they check the checkbox (before clicking anywhere else). The keyboard will hide, but when you click back into the input, it comes back. Once this has happened, the keyboard no longer hides when you click outside of it either.

If they have clicked away from the input, before they uncheck the box, it behaves as expected and goes away until they re-check the box.

I've created a very basic fiddle of this behaviour:
http://jsfiddle.net/n2yh4ym9/

I've tried adding .close() and triggering blur on the input before the destroy call with no luck.

Any ideas on what i'm doing wrong, or how to tweak this to work?
Thanks!

@Mottie
Copy link
Owner

Mottie commented Mar 11, 2015

Hi @patriciavandermeer!

The demo is the standard playground demo, but I set up a different one and noticed that this was a problem. I'll work on a fix asap!

@Mottie Mottie added the Bug label Mar 11, 2015
@patriciavandermeer
Copy link
Author

Oh no!

I must have no saved my fork of it properly. I'm sorry!! I had a little demo all built up (i used the playground as a base and stripped everything out).

Sorry about that, I'll pay more attention to my fiddle saving in the future!

@Mottie
Copy link
Owner

Mottie commented Mar 11, 2015

LOL no worries ;)

@Mottie Mottie closed this as completed in 0556a74 Mar 11, 2015
@Mottie
Copy link
Owner

Mottie commented Mar 11, 2015

Ok, it should be all fixed now.

Here is the demo I was working with: http://jsfiddle.net/Mottie/n2yh4ym9/1/ (you might need to give it a few minutes for the demo files to update)

@Mottie
Copy link
Owner

Mottie commented Mar 11, 2015

Grr, ok I don't know why the demo isn't working... but I have it working perfectly locally.

@Mottie
Copy link
Owner

Mottie commented Mar 11, 2015

Well, it started working when I copied the code exactly from my local demo:

http://jsfiddle.net/Mottie/n2yh4ym9/2/

Sooo odd. But now it works 😸

Update: Duh... the first demo had a capital "K" in $kb.getkeyboard();

@patriciavandermeer
Copy link
Author

awesome thanks for fixing this so quickly!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants