Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with buttonHover class in Altkeys popup #556

Closed
oz1cz opened this issue Apr 28, 2017 · 1 comment
Closed

Problem with buttonHover class in Altkeys popup #556

oz1cz opened this issue Apr 28, 2017 · 1 comment

Comments

@oz1cz
Copy link

oz1cz commented Apr 28, 2017

When a popup is displayed, there is an error in handling the css.buttonHover (typically "ui-state-hover") class:

  1. Go to the demonstration page, docs/altkeys-popup.html.
  2. Use your mouse to press the 'a' key long enough to bring up the popup. Note that the 'å' character is highlighted.
  3. Move the mouse into the 'æ' character (be careful that the mouse does not enter any other key before it reaches 'æ').
  4. Now both 'å' and 'æ' are highlighted.

This can be fixed thus:
In jquery.keyboard.extension-altkeyspopup.js lines 291-293 (from version v1.26.21) replace

		} else {
			$( this ).addClass( base.options.css.buttonHover );`
		}

with

		} else {
			$keys.removeClass( base.options.css.buttonHover );
			$( this ).addClass( base.options.css.buttonHover );
		}

(I don't know if this is the simplest or best fix.)

@Mottie
Copy link
Owner

Mottie commented Apr 28, 2017

Hi @oz1cz!

Thanks again for your help and attention to details! I'll have this fixed shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants