Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread pool model update / salvage old PR #2294

Closed
Cervator opened this issue Apr 13, 2016 · 1 comment
Closed

Thread pool model update / salvage old PR #2294

Cervator opened this issue Apr 13, 2016 · 1 comment
Labels
Category: Performance Requests, Issues and Changes targeting performance Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.

Comments

@Cervator
Copy link
Member

Cervator commented Apr 13, 2016

Creating this issue in favor of keeping PR #1760 open any longer. There may still be value in those changes to salvage but I'm not sure @prestidigitator will have time to get back to it any time soon.

Just in case to safeguard the branch I've made a copy in our test org repo: https://github.com/Nanoware/Terasology/tree/threading

Not necessarily a topic for the faint of heart, threading is fun!

A good usage of a thread pool is the work / task system in Light & Shadow (or even Miniion/MasterOfOreon), although it admittedly may not be in the best shape itself.

Maybe related: #1770, #1737, #1296

Edit: An additional topic here could be adding some configuration for thread pools, such as limiting chunk generator threads to available cores minus 1 or 2 (min 1, of course). World gen can really chew through processing at times, to the point where a poorly cooled system or one doing a lot of multitasking could hit some trouble.

@Cervator Cervator added Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Category: Performance Requests, Issues and Changes targeting performance labels Apr 13, 2016
@pollend pollend closed this as completed Jul 22, 2021
@pollend
Copy link
Member

pollend commented Jul 22, 2021

superseded by : #4798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Performance Requests, Issues and Changes targeting performance Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Projects
None yet
Development

No branches or pull requests

2 participants