Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update DI to remove usage of Context/CoreContext #4508

Open
pollend opened this issue Feb 13, 2021 · 1 comment
Open

update DI to remove usage of Context/CoreContext #4508

pollend opened this issue Feb 13, 2021 · 1 comment

Comments

@pollend
Copy link
Member

pollend commented Feb 13, 2021

CoreContext is a bit of a large bin and it makes setting up a test environment hard and unmaintainable. the order of dependencies is coupled to the engine so setting something up in a more limited fashion ends up becoming a bit of a Easter egg hunt of finding the relevant dependencies to inject into the context. There is some PR's that we can't use at the moment since the changes introduced are for a much older version of the enigne. some of the changes are relevant when this is approached in the future after upgrading gestalt.

PR's for reference

@keturn
Copy link
Member

keturn commented May 3, 2021

removing this from the project board to narrow that board's scope to things required for the module & asset migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants