Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin #55

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

MrAsterisco
Copy link
Owner

This PR updates the Python plugin after the merge of MrAsterisco/hisensetv#3.

@MrAsterisco MrAsterisco linked an issue May 14, 2024 that may be closed by this pull request
@MrAsterisco
Copy link
Owner Author

@LeLunZ, can you please check if this update works with the latest version of Python?

@LeLunZ
Copy link
Collaborator

LeLunZ commented May 14, 2024

So:

  • tested the python script also with 3.12
  • tested the homebridge plugin with the latest homebridge version

Something not related to the PR:
The only problem I encounter (but that was also before the upgrade), is that somehow the Source Texts in Homekit are messed up.
I will create another issue for that. (but its nothing important)
Just saw the known issue section lol

Also can you tell me why in general the authorization step is needed. What does it do? From what I can see, in the code, there is no secret stored and send again to the tv after for example homebridge reboots.
I can also control the tv from devices where I didn't do the authorization. So I don't really get why its needed.

@MrAsterisco
Copy link
Owner Author

@LeLunZ so can I go ahead and merge this PR? 😊

The authorization code is required for most models to pair the phone with the TV. I'm not aware of models that work without pairing first. The TV saves the phone (or device) MAC address somewhere and only accepts commands from known MAC addresses.

@LeLunZ
Copy link
Collaborator

LeLunZ commented May 14, 2024

Yes :)

Then it could be that I already paired my Laptop 👍 thought I didn’t but I guess I forgot. (My first time setting up the Mqtt connection was a few years back)

@MrAsterisco MrAsterisco merged commit b2dd1b7 into master May 15, 2024
10 checks passed
@MrAsterisco MrAsterisco deleted the 54-update-to-latest-version-of-the-python-plugin branch May 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest version of the Python plugin
2 participants