Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button wont resize to square? | no name/status when 'off' #157

Closed
Mariusthvdb opened this issue Feb 13, 2023 · 4 comments · Fixed by #162
Closed

button wont resize to square? | no name/status when 'off' #157

Mariusthvdb opened this issue Feb 13, 2023 · 4 comments · Fixed by #162
Labels
bug Something isn't working

Comments

@Mariusthvdb
Copy link

Mariusthvdb commented Feb 13, 2023

Describe the bug

or, like custom:button-card, use aspect ratio: 1/1 when in a grid (which should default to square: true)

Scherm­afbeelding 2023-02-13 om 17 12 23

also, with the default config like below, there is no caption/headline at all, would be nice if it said so, like the KNMI integration does

Scherm­afbeelding 2023-02-13 om 17 16 04

and show Green, not black/transparent

color would be even more required on a full scale card:

Scherm­afbeelding 2023-02-13 om 17 25 37

Aware we can set it to Not show when 'off', but personally I love the positive feedback, and be sure there is no alert.

Steps to reproduce

see yaml below, not much more to do

Screenshots

No response

Card version

v2.4.2

Integration type

Meteoalarm

Installation type

Home Assistant Community Store (HACS)

Card Configuration

 - type: grid
    columns: 4
    cards:

      - !include /config/dashboard/includes/button/include_button_animated_weather.yaml

      - !include /config/dashboard/includes/button/include_button_wind_direction.yaml

      - !include /config/dashboard/includes/button/include_button_knmi_waarschuwing.yaml

      - type: custom:meteoalarm-card
        integration: meteoalarm
        entities: binary_sensor.meteoalarm_brabant
#         override_headline: false
#         hide_when_no_warning: true

Integration Configuration

No Yaml, just the Meteoalarm integration setup in the UI for Noord-Brabant (NL)

@Mariusthvdb Mariusthvdb added the bug Something isn't working label Feb 13, 2023
@MrBartusek
Copy link
Owner

Yes, as per title, this is a bug that will be fixed

for other stuff:

also, with the default config like below, there is no caption/headline at all, would be nice if it said so, like the KNMI integration does

there is no headline when you have such small card, there is no place to put it anywhere

and show Green, not black/transparent

this doesn't match the home assistant styling, you can make such changes using https://github.com/thomasloven/lovelace-card-mod

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Feb 16, 2023

thanks for fixing the square!

what exactly do you mean by:

this doesn't match the home assistant styling

there is no such thing as a default styling for these custom elements?

unless you mean HA follows the raw device data, and Meteoalarm has no colors either on those safe places...

Scherm­afbeelding 2023-02-16 om 14 33 31

providing only these:
Scherm­afbeelding 2023-02-16 om 14 33 38

the yellow btw is #ffd41c (rgb(255, 212, 28)) and 'more yellow' than the one you use in

new MeteoalarmLevelInfo(MeteoalarmLevelType.Yellow, 'Yellow', '#ff9800'),

would you oppose changing that? it would certainly result in more contrast to the real orange in #fd7f09 (rgb(253, 127, 9)) meteoalarm site and red #fc0005 (rgb(252, 0, 5) )

@MrBartusek
Copy link
Owner

there is no such thing as a default styling for these custom elements?

Cards are gray not green most of the time

As for the yellow, its the yellow for ha css varables

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Feb 16, 2023

Right thanks

If it's for bringing across the Meteoalarm styling, why not copy those colors ?

Ha styling has nothing to do with the Meteoalarm styling and, tbh, is not very generic either.

Being a Meteoalarm card would be reason enough to use their 'brand' coloring if you'd ask me.

It's very easy change ;/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants