Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Use Full Content Width #10

Open
Zethson opened this issue May 20, 2021 · 6 comments
Open

Add Option to Use Full Content Width #10

Zethson opened this issue May 20, 2021 · 6 comments

Comments

@Zethson
Copy link

Zethson commented May 20, 2021

Hey,

I was waiting for this forever and I hope that you will maintain this!

Anyways,

.wy-nav-content {
    max-width: none;
}

is always required as custom css to use the full width of the screen. What do you think about making this a default?

@MrDogeBro
Copy link
Owner

Could you show a picture of the difference? This extension is for dark mode tho, and therefore if its not related to theming, it may not be added. We would have to see.

@MrDogeBro MrDogeBro added status/pending type/enhancement New feature or request labels May 20, 2021
@Zethson
Copy link
Author

Zethson commented May 20, 2021

It goes slightly beyond theming, so I guess not. I just patch my own css

@Zethson Zethson closed this as completed May 20, 2021
@MrDogeBro
Copy link
Owner

Ok, could you show a picture tho? There is a potential that it could always just be added as an extra option that can be enabled in the config.

@Zethson
Copy link
Author

Zethson commented May 20, 2021

@MrDogeBro look at this for example: https://sc-toolbox.readthedocs.io/en/latest/installation.html

It uses the full width of the screen. The default of the theme only uses like 400 pixels or something (I forgot)

@MrDogeBro
Copy link
Owner

Yeah I see — thats what I thought you were talking about. What do you think about just a bool config option for toggling in (off by default)?

@Zethson
Copy link
Author

Zethson commented May 20, 2021

Yeah sure, why not.

@MrDogeBro MrDogeBro reopened this May 20, 2021
@MrDogeBro MrDogeBro changed the title Use full content width by default Add option to use full content width May 28, 2021
@MrDogeBro MrDogeBro changed the title Add option to use full content width Add Option to Use Full Content Width Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants