Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelmon Reforgeged from ATLauncher will download both server and client version #3764

Closed
1 task done
Malachiel87 opened this issue May 5, 2021 · 5 comments
Closed
1 task done
Labels

Comments

@Malachiel87
Copy link

Operating System

Windows

Description of bug

Downloading Pixelmon Reforget from ATLauncher integration of MULTIMC it will download both server version mod and client mod

Steps to reproduce

download Pixemon Reforget from ATlauncher

Suspected cause

I have to delete server version mod from be able to launch Pixelmon Reforged

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@Malachiel87 Malachiel87 added the bug label May 5, 2021
@spannerman79
Copy link

Looking at https://download.nodecdn.net/containers/atl/packs/PixelmonMod/versions/Pixelmon-8.1.2/Configs.json in specific;

        {
            "name": "Pixelmon Server",
            "version": "8.1.2",
            "url": "https://download.nodecdn.net/containers/reforged/server/release/8.1.2/Pixelmon-1.12.2-8.1.2-server.jar",
            "file": "Pixelmon-1.12.2-8.1.2-server.jar",
            "download": "direct",
            "md5": "8c78b855f4958544dec483af4b49cc32",
            "force": false,
            "colour": "Green",
            "type": "mods",
            "client": false,
            "optional": false,
            "server": true,
            "selected": false,
            "recommended": true,
            "hidden": false,
            "library": false,
            "description": "Pokemon in Minecraft.",
            "website": "https://www.pixelmonmod.com/",
            "authors": [
                "PixelmonMod"
            ]
        },

The issue here by the looks of it the server jar is being classed as a mod - which if this is the way that the ATLauncher system works its well... stupid.

@jamierocks
Copy link
Contributor

The important part is really:

            "client": false,
            "optional": false,
            "server": true,

I already ignore optional mods, but forgot to ignore non-client mods. I've got a patch locally that resolves this, I just wasn't able to get the Pixelmon pack to finish installing.

Will return to it shortly.

@jamierocks
Copy link
Contributor

Also @spannerman79 I suspect that's just a server-specifc build of Pixelmon, since it's still installed into mods. I can only assume it has the (perhaps large) client assets removed.

@Malachiel87
Copy link
Author

what about turning "server": to false, ?

jamierocks added a commit to jamierocks/MultiMC5 that referenced this issue May 6, 2021
@jamierocks
Copy link
Contributor

Fixed by df7873e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants