Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Multiverse overriding external PlayerSpawnLocationEvent #2752

Open
2 tasks done
kyngs opened this issue Jan 17, 2022 · 4 comments
Open
2 tasks done

[Bug]: Multiverse overriding external PlayerSpawnLocationEvent #2752

kyngs opened this issue Jan 17, 2022 · 4 comments
Labels
Bug: Unconfirmed Unsure if the issue/bug is valid.

Comments

@kyngs
Copy link

kyngs commented Jan 17, 2022

/mv version -p output

https://j.mp/3fyUAsU

Server logs

https://paste.gg/p/anonymous/fda5f5bb8f374f4abce5a3e0ddcff1e5

Server Version

[14:33:42 INFO]: Checking version, please wait...
[14:33:42 INFO]: This server is running Paper version git-Paper-155 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 99cf01f)
You are running the latest version
Previous version: git-Paper-82 (MC: 1.18.1)

Bug Description

Please take look here: PaperMC/Paper#7361. I have isolated the issue to Multiverse-Core

Steps to reproduce

Please take look here: PaperMC/Paper#7361

Agreements

  • I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
  • I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.
@kyngs kyngs added the Bug: Unconfirmed Unsure if the issue/bug is valid. label Jan 17, 2022
@kyngs
Copy link
Author

kyngs commented Jan 19, 2022

So this can be changed in the config, tho I still believe that the mechanism shouldn't be placed in PlayerJoinEvent, but in PlayerSpawnLocationEvent. And possibly even with low priority, so it can be overridden by other plugins.

@benwoo1110
Copy link
Member

I recall that PlayerSpawnLocationEvent may not be available on craftbukkit, not sure if it's on 1.13 as well. So breaking change may be needed to implement this.

@kyngs
Copy link
Author

kyngs commented Mar 27, 2022

I am sure it can, if you turn off the override-spawn-location option in the config (which is the default on), the problem stops appearing. Maybe put it to a bit lower priority, so it still can be overridden?

@benwoo1110
Copy link
Member

I'm not talking about config option or priority, I'm referring to bukkit api version support for that event method.

@benwoo1110 benwoo1110 mentioned this issue Feb 10, 2023
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Unconfirmed Unsure if the issue/bug is valid.
Projects
None yet
Development

No branches or pull requests

2 participants