Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check permissions one tick after PlayerJoinEvent #981

Closed
main-- opened this issue Nov 26, 2012 · 4 comments
Closed

Check permissions one tick after PlayerJoinEvent #981

main-- opened this issue Nov 26, 2012 · 4 comments
Labels
PR: Better Coding Improvements in code, but not introducing new features. Type: Idea Suggestion for a new feature or enhancement.

Comments

@main--
Copy link
Member

main-- commented Nov 26, 2012

From #multiverse:

<Aikar>also i have a suggestion -- for the force gamemode change on worldchange/login -- can the permission check be done in the runnable on next tick so that its ensured the player will have permissions applied already?
<Aikar>MV and our plugin both did PlayerJoinEvent on default priority and MV was registering that before we applied the permission node. checking next tick will make it not care whos event fired first

@Multiverse/core-development-team Your opinion?

@Lunaphied
Copy link

Sounds like a good idea, I will try and get some code in for this when I get a chance tonight.

@dumptruckman
Copy link
Member

@modwizcode just fyi, I don't think doing it a tick later is the proper way to handle this.

@Lunaphied
Copy link

I didn't think so either, thats why I didn't talk about ease or anything ;)

@benwoo1110 benwoo1110 added Type: Idea Suggestion for a new feature or enhancement. and removed PR: Enhancement Pull requests to implement a feature or improvement in code. labels Oct 12, 2020
@benwoo1110
Copy link
Member

Combine with #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Better Coding Improvements in code, but not introducing new features. Type: Idea Suggestion for a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants