Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SCMP #54

Closed
4 tasks done
mlegner opened this issue Nov 28, 2023 · 2 comments · Fixed by #125
Closed
4 tasks done

Implement SCMP #54

mlegner opened this issue Nov 28, 2023 · 2 comments · Fixed by #125
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mlegner
Copy link
Contributor

mlegner commented Nov 28, 2023

  • How is ICMP handled typically?
  • How does the Go code handle SCMP? -> snet.packet, slayers.scmp_msg
  • How should our interface look like to send SCMP packets? Raw SCION socket?
  • Potentially refactor UDP socket to build on this raw socket?
@mlegner mlegner added this to the MVP milestone Nov 28, 2023
@jpcsmith
Copy link
Contributor

jpcsmith commented Dec 4, 2023

The UDP man pages states that received errors are returned on subsequent calls to the socket. Additionally, errors can be set to be collected and requested using a separate API.

Error handling
All fatal errors will be passed to the user as an error return even when the socket is not
connected. This includes asynchronous errors received from the network. You may get an
error for an earlier packet that was sent on the same socket. This behavior differs from
many other BSD socket implementations which don't pass any errors unless the socket is
connected. Linux's behavior is mandated by RFC 1122.
[...]
When the IP_RECVERR option is enabled, all errors are stored in the socket error queue,
and can be received by recvmsg(2) with the MSG_ERRQUEUE flag set.

@jpcsmith
Copy link
Contributor

jpcsmith commented Dec 4, 2023

The SCMP message handling can be seen in netsec-ethz/scion-apps/blob/master/pkg/pan/raw.go, which used by their UDP socket.

Their current approach is to notify the PathStats monitor that the path in the message is down when the socket receives either ExternalInterfaceDown or InternalConnectivityDown. All other SCMP messages are propagated as an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants