Skip to content

Commit

Permalink
Ah, github secrets cannot be used in PRs from forked repos.
Browse files Browse the repository at this point in the history
  • Loading branch information
mkelley committed Jul 6, 2022
1 parent fb7f327 commit 3ef8660
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci_cron_weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,6 @@ jobs:
run: |
python -m pip install --upgrade pip tox
- name: Test with tox
env:
ADS_DEV_KEY: ${{ secrets.ADS_DEV_KEY }}
run: tox ${{ matrix.toxargs}} -e ${{ matrix.toxenv}} -- ${{ matrix.toxposargs}}
5 changes: 1 addition & 4 deletions .github/workflows/ci_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@ jobs:
python: 3.8
toxenv: py38-test-alldeps

- name: Python 3.8 with all optional dependencies, remote tests, and coverage checking
- name: Python 3.8 with all optional dependencies and coverage checking
os: ubuntu-latest
python: 3.8
toxenv: py38-test-alldeps-cov
toxposargs: --remote-data

# - name: Windows - Python 3.8 with all optional dependencies
# os: windows-latest
Expand Down Expand Up @@ -88,8 +87,6 @@ jobs:
python -m pip install --upgrade pip
python -m pip install tox codecov
- name: Test with tox
env:
ADS_DEV_KEY: ${{ secrets.ADS_DEV_KEY }}
run: tox ${{ matrix.toxargs }} -e ${{ matrix.toxenv }} -- ${{ matrix.toxposargs }}

# This is an example of how to upload coverage to codecov
Expand Down

0 comments on commit 3ef8660

Please sign in to comment.