From 3ef866035becf0cea80ae6611a11719aa99af30a Mon Sep 17 00:00:00 2001 From: "Michael S. P. Kelley" Date: Wed, 6 Jul 2022 11:28:42 -0400 Subject: [PATCH] Ah, github secrets cannot be used in PRs from forked repos. --- .github/workflows/ci_cron_weekly.yml | 2 ++ .github/workflows/ci_tests.yml | 5 +---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_cron_weekly.yml b/.github/workflows/ci_cron_weekly.yml index 1969c504..7ba6cfb3 100644 --- a/.github/workflows/ci_cron_weekly.yml +++ b/.github/workflows/ci_cron_weekly.yml @@ -34,4 +34,6 @@ jobs: run: | python -m pip install --upgrade pip tox - name: Test with tox + env: + ADS_DEV_KEY: ${{ secrets.ADS_DEV_KEY }} run: tox ${{ matrix.toxargs}} -e ${{ matrix.toxenv}} -- ${{ matrix.toxposargs}} diff --git a/.github/workflows/ci_tests.yml b/.github/workflows/ci_tests.yml index a32ea031..2174b3cc 100644 --- a/.github/workflows/ci_tests.yml +++ b/.github/workflows/ci_tests.yml @@ -42,11 +42,10 @@ jobs: python: 3.8 toxenv: py38-test-alldeps - - name: Python 3.8 with all optional dependencies, remote tests, and coverage checking + - name: Python 3.8 with all optional dependencies and coverage checking os: ubuntu-latest python: 3.8 toxenv: py38-test-alldeps-cov - toxposargs: --remote-data # - name: Windows - Python 3.8 with all optional dependencies # os: windows-latest @@ -88,8 +87,6 @@ jobs: python -m pip install --upgrade pip python -m pip install tox codecov - name: Test with tox - env: - ADS_DEV_KEY: ${{ secrets.ADS_DEV_KEY }} run: tox ${{ matrix.toxargs }} -e ${{ matrix.toxenv }} -- ${{ matrix.toxposargs }} # This is an example of how to upload coverage to codecov