Fix and test STScI Sun URLs #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkelley
force-pushed
the
fix-and-test-stsci-sun-urls-2022.06
branch
from
d439cf2 to
3767872
Compare
mkelley
force-pushed
the
fix-and-test-stsci-sun-urls-2022.06
branch
from
3767872 to
7a3552d
Compare
|
I don't see a way to get ADS queries to run with remote tests on PRs without exposing the secret API key. I've disabled remote tests in PRs, restoring the previous behavior. One path forward is to use ads's sandbox |
jianyangli
reviewed
Jul 6, 2022
There was a problem hiding this comment.
@mkelley I'm not really familiar with the test set up, so I don't feel qualified to review the .yml and tox.ini. Maybe you should get someone else to check those parts?
|
Maybe @migueldvb can give them a quick look? |
mkelley
force-pushed
the
fix-and-test-stsci-sun-urls-2022.06
branch
from
3ef8660 to
e9dec05
Compare
jianyangli
approved these changes
Jul 22, 2022
Test is presently failing. This will help mitigate the effects of small orbital changes at JPL Horizons.
This reverts commit 17bc0d6.
mkelley
force-pushed
the
fix-and-test-stsci-sun-urls-2022.06
branch
from
cbaba8d to
a1fb6b2
Compare
|
Looks great, sorry I missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #342 and update weekly tests to hopefully more quickly find issues like this. Also, fix a bug in the CI github workflow that was not including remote tests.