Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Population page - state other than Susc shows X #892

Open
missyschoenbaum opened this issue Sep 14, 2018 · 6 comments
Open

Population page - state other than Susc shows X #892

missyschoenbaum opened this issue Sep 14, 2018 · 6 comments
Assignees

Comments

@missyschoenbaum
Copy link
Contributor

This is minor, but odd.

Any state other than susceptible shows an X (like infected). There are states like nat immune, vaccine immune and destroyed where that would be weird.

We can fix when we have time.
destinitialstate

@missyschoenbaum
Copy link
Contributor Author

A best case on this might be to have more than one icon. For example, if I wanted to build a population for endemic disease, I would start most of the units in immune (vx or natural). That would be useful to see as a distinct state. @lkholmstrom do you have any images that might help us understand this better?

@ConradSelig
Copy link
Contributor

This would be relatively easy with the right icons. If you want me to make some icons I would be more than happy to give a shot at it.

Otherwise non-infected units definitely should not be showing as a red X on the map, I should be able to render them as a regular dot fairly easy if you want to do a small patch on the bug portion of this ticket.

Estimates:
Add new icons for each disease state and implement: 4-5 hours
Fix bug where non-infected units are being displayed as infected: 1-2 hours

@missyschoenbaum
Copy link
Contributor Author

Just to clarify, all units that are not susceptible show as X - this may be any disease state, or any immune state.

@missyschoenbaum
Copy link
Contributor Author

To clarify again - most disease states should have an X, (so that is L, B, C ) but S, V, D and N should not. On the Noun project, I found an icon that I like for V,D,N if it will allow color to show through. Still not sure if I want to commit 5 hours to it.

@missyschoenbaum
Copy link
Contributor Author

forgot image
ImmuneShield

@ConradSelig
Copy link
Contributor

Not sure I want to stick to that estimate - it was almost a year ago. Then again, I haven't really looked at the Population map since.
@missyschoenbaum Your call if you want to pursue this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants