Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for reading sfc fluxes (DEPHYv1) #427

Closed
hertneky opened this issue Jan 24, 2024 · 4 comments
Closed

Bug fix for reading sfc fluxes (DEPHYv1) #427

hertneky opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
bug CCPP v7 Needed for CCPP v7 public release

Comments

@hertneky
Copy link
Collaborator

hertneky commented Jan 24, 2024

Surface fluxes are not read correctly when running the SCM using DEPHYv1 format.

This issue was uncovered from LSM testing from Xia Sun awhile ago. I had mistakenly though that Grant had pulled the fixes into a PR he had open at the time. The issue was uncovered again when @egrell was attempting to run the DEPHY MPACE case.

@hertneky hertneky added the bug label Jan 24, 2024
@hertneky hertneky self-assigned this Jan 24, 2024
@dustinswales
Copy link
Collaborator

@hertneky Can you add some details to the issue? (e.g. How did you identify the problem?)

@hertneky
Copy link
Collaborator Author

@dustinswales I added more details. Evelyn tested the fixes with MPACE, but I will also test with the ISDAC DEPHY case

@mzhangw
Copy link
Collaborator

mzhangw commented Jan 25, 2024

The issue in coupling to LSM was reported by Dr. Xia Sun from GSL, but not from me.

@hertneky
Copy link
Collaborator Author

@mzhangw You are absolutely right! My mistake!

@scrasmussen scrasmussen added the CCPP v7 Needed for CCPP v7 public release label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CCPP v7 Needed for CCPP v7 public release
Projects
None yet
Development

No branches or pull requests

4 participants