Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assets to comply with the New NSF Branding Theme #540

Closed
erogluorhan opened this issue Jan 22, 2024 · 4 comments · Fixed by #541 or #545
Closed

Update assets to comply with the New NSF Branding Theme #540

erogluorhan opened this issue Jan 22, 2024 · 4 comments · Fixed by #541 or #545
Assignees

Comments

@erogluorhan
Copy link
Collaborator

Update documentation site, pages, etc. to reflect the NSF branding policy changes (e.g. NSF NCAR) whereever applicable, e.g. logos, text, etc.

@cyschneck cyschneck self-assigned this Jan 23, 2024
@cyschneck cyschneck mentioned this issue Jan 23, 2024
9 tasks
@erogluorhan
Copy link
Collaborator Author

@cyschneck I just noticed a small issue with the logo:

image

"NCAR" is not visible with the light version of it; the dark version could be better.

@kafitzgerald
Copy link
Contributor

Shoot! I'll have to fix this over on viz as well. It looks like the "light" logos are for use with dark themes.

Our dark theme in general is pretty tough to read as well (w/ the navy headers). That's another issue though.

@cyschneck
Copy link
Contributor

This was handy, let's the theme decide which version of the logo to use:

html_theme_options = {
    "logo": {
        "image_light": "_static/images/logos/NSF_NCAR_light.png",
        "image_dark": "_static/images/logos/NSF_NCAR_dark.png",
    }
}

@erogluorhan
Copy link
Collaborator Author

This is cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants