PathAccessException in cleanup.dart

[thePeras]

A high rated exception captured by sentry in IOS devices only.

PathAccessException: Deletion failed, path = '/var/mobile/Containers/Data/Application/6E634CF6-78CB-433A-B01B-314123214/Documents' (OS Error: Operation not permitted, errno = 1)

Proposed solution:

• Use getApplicationSupportDirectory instead of getApplicationDocumentsDirectory. (or use getApplicationSupportDirectory for IOS and the other for android)
• Delete the files individually

[limwa]

Furthermore, in cleanup.dart, some race conditions might be causing other errors.

uni/uni/lib/controller/cleanup.dart

Lines 18 to 43 in d82e5a2

	Future<void> cleanupStoredData(BuildContext context) async {
	StateProviders.fromContext(context).invalidate();
	final prefs = await SharedPreferences.getInstance();
	final faculties = PreferencesController.getUserFaculties();
	await prefs.clear();
	unawaited(
	Future.wait([
	AppLecturesDatabase().deleteLectures(),
	AppExamsDatabase().deleteExams(),
	AppCoursesDatabase().deleteCourses(),
	AppUserDataDatabase().deleteUserData(),
	AppLastUserInfoUpdateDatabase().deleteLastUpdate(),
	AppBusStopDatabase().deleteBusStops(),
	AppCourseUnitsDatabase().deleteCourseUnits(),
	NetworkRouter.killSigarraAuthentication(faculties),
	]),
	);
	final path = (await getApplicationDocumentsDirectory()).path;
	final directory = Directory(path);
	if (directory.existsSync()) {
	directory.deleteSync(recursive: true);
	}
	}

The race conditions I've found are the following:

1. In line 19, the providers are invalidated, which causes them to reload data from the remotes. However, in lines 25 through 36, the database tables are deleted. The data, therefore, might be stored a database table which is then deleted.
2. In lines 25 through 36, the database tables are deleted, but these operations are unawaited. In lines 38 through 42, all files inside the documents folder are deleted, which includes the database files. Therefore, sqflite is trying to send a delete table command to a file that might not exist anymore. The database connections should be closed before the database files are removed.