General and Secondary new UI #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adriano-7
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
It's looking awesome! I only have one suggestion, for now let's make the light mode the default as we still haven't decided the colors for the dark mode (maybe for the release i think we should even disable that feature). Otherwise it looks great, some widgets are breaking (what used to be gray text is now white making the text disapear but i think it's not necessarily a problem as this widgets will be replaced).
The UI is already looking 10x better 🔥
thePeras
force-pushed
the
ui/page-layouts
branch
from
d346d3c to
7e51043
Compare
thePeras
force-pushed
the
ui/page-layouts
branch
from
27239b5 to
a609efd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1435 +/- ##
===========================================
Coverage 11% 11%
===========================================
Files 270 270
Lines 7357 7357
===========================================
Hits 807 807
Misses 6550 6550 |
thePeras
force-pushed
the
ui/page-layouts
branch
from
0663a54 to
feca9a6
Compare
thePeras
force-pushed
the
ui/page-layouts
branch
from
a46d7b6 to
f8a4f55
Compare
DGoiana
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1428
Reuse previous implementations and just adjust the ui.
Some General Pages examples
Secondary Pages examples