Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing HomePage #1442

Draft
wants to merge 28 commits into
base: ui/redesign
Choose a base branch
from
Draft

Implementing HomePage #1442

wants to merge 28 commits into from
+1,667 −8

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Jan 14, 2025 •
edited
Loading

Closes #1429

TODO:

  • delete old code
  • logic of schedule card on top
  • rearrange button position
  • simplify save/delete favorite logic (?)
  • restaurant and services cards
  • icons
  • fix misalignment when dragging cards
  • translations

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana changed the base branch from develop to ui/redesign January 14, 2025 15:55
@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 14, 2025

The first concern is the notch.

  • Without SafeArea():
  • With SafeArea():

@DGoiana DGoiana marked this pull request as draft January 20, 2025 15:07
@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 21, 2025

@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 31, 2025

Current state:

teste

@thePeras
Copy link
Member

From seen the video the dragging experience is awesome!

I notice an UX problem, the place to display the current elements is too short. Maybe the top bar is unnecessary. We can discuss this in the next meeting

@DGoiana
Copy link
Collaborator Author

DGoiana commented Jan 31, 2025 •
edited
Loading

@thePeras It is. We can drop the top bar or maybe short the bottom one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePeras thePeras thePeras left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Homepage
3 participants
@DGoiana @thePeras @Process-ing