Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: profile page #1447

Open
wants to merge 30 commits into
base: ui/redesign
Choose a base branch
from
Open

feat: profile page #1447

wants to merge 30 commits into from

Conversation

vitormpp
Copy link
Member

@vitormpp vitormpp commented Jan 21, 2025

Closes #1431

Profile page

(with red icons)

Preview

English Portuguese

Discussion

  • Larger text sizes, such as those resulting from phone settings, may cause overflow issues in the Profile Info section (Balance/Deadline/Print Balance). Should we leave this behavior as is, or implement text wrapping or horizontal scrolling?
  • Overflow ellipsis in settings (eg. "Partilhar estatísticas de u...")?
  • The "Theme Switch Button" (ThemeSwitchButton) and "Locale Switch Button" (LocaleSwitchButton, for language selection) have hardcoded size constraints to match the dimensions of the Flutter Switch.
  • The "Theme Switch Button" will be temporarily commented out due to the lack of a dark theme implementation.

@DGoiana DGoiana changed the base branch from develop to ui/redesign January 21, 2025 16:28
@thePeras
Copy link
Member

Make the icons red!!

@vitormpp vitormpp changed the title Feature/profile page feat: profile page Jan 21, 2025
@DGoiana
Copy link
Collaborator

DGoiana commented Jan 28, 2025

The code looks good and ready to be merged. Answering your first two questions:

  1. I think horizontal scrolling on the cards might be the best mechanism.
  2. I do not mind being overflowed, however it may not be user-friendly, so I think a wrap should be the solution
  3. Keep the hard coded constraints
  4. Leave it as it its

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Profile page
3 participants