Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial user info page #295

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

initial user info page #295

wants to merge 29 commits into from

Conversation

peucastro
Copy link
Member

@peucastro peucastro commented Nov 16, 2024 •
edited
Loading

Closes #284

Screenshots

Desktop version Mobile version

Review checklist

  • Contains enough appropriate tests
  • Behavior is as expected
  • Clean, well-structured code

@peucastro peucastro marked this pull request as ready for review December 4, 2024 16:04
@MRita443 MRita443 self-requested a review January 8, 2025 16:37
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 184 lines in your changes missing coverage. Please review.

Project coverage is 0.53%. Comparing base (8df04ba) to head (dfc9932).

Files with missing lines Patch % Lines
src/routes/(app)/user/[id]/+page.svelte 0.00% 102 Missing and 1 partial ⚠️
...app)/user/_components/social-media-icon.stories.ts 0.00% 36 Missing and 1 partial ⚠️
...es/(app)/user/_components/social-media-icon.svelte 0.00% 19 Missing and 1 partial ⚠️
src/routes/(app)/user/[id]/+page.ts 0.00% 10 Missing and 1 partial ⚠️
...p)/team/_components/team-member-hexagon.stories.ts 0.00% 7 Missing ⚠️
src/lib/components/icons/icons.ts 0.00% 2 Missing ⚠️
src/routes/(app)/+error.svelte 0.00% 2 Missing ⚠️
.../(app)/team/_components/team-member-hexagon.svelte 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #295       +/-   ##
===========================================
- Coverage    85.62%   0.53%   -85.10%     
===========================================
  Files           27      68       +41     
  Lines          327    2998     +2671     
  Branches        88      70       -18     
===========================================
- Hits           280      16      -264     
- Misses          47    2916     +2869     
- Partials         0      66       +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rubuy-74
rubuy-74 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, there are only small things that could be a little different. 😄

src/routes/(app)/user/[id]/+page.svelte Outdated Show resolved Hide resolved
src/routes/(app)/user/[id]/+page.svelte Show resolved Hide resolved
src/routes/(app)/user/[id]/+page.svelte Outdated Show resolved Hide resolved
@MRita443 MRita443 requested a review from rubuy-74 January 17, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRita443 MRita443 Awaiting requested review from MRita443

@rubuy-74 rubuy-74 Awaiting requested review from rubuy-74

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user: info page
2 participants
@peucastro @rubuy-74