From eb0004ce3b57ee52766612fb89b48e5465a6e6a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niccol=C3=B2=20Laurenti?= <niclaurenti@gmail.com>
Date: Tue, 9 Jan 2024 16:29:45 +0100
Subject: [PATCH] Pass nl as an argument in qed beta functions

---
 src/eko/beta.py      | 16 +++++++---------
 src/eko/constants.py |  2 --
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/src/eko/beta.py b/src/eko/beta.py
index 8ce6658f1..6d8b77ec2 100644
--- a/src/eko/beta.py
+++ b/src/eko/beta.py
@@ -32,7 +32,7 @@ def beta_qcd_as2(nf):
 
 
 @nb.njit(cache=True)
-def beta_qed_aem2(nf):
+def beta_qed_aem2(nf, nl=3):
     r"""Compute the first coefficient of the QED beta function.
 
     Implements Eq. (7) of :cite:`Surguladze:1996hx`.
@@ -50,7 +50,6 @@ def beta_qed_aem2(nf):
     """
     nu = constants.uplike_flavors(nf)
     nd = nf - nu
-    nl = 3  # TODO : pass nl as an argument??
     beta_qed_aem2 = (
         -4.0 / 3 * (nl + constants.NC * (nu * constants.eu2 + nd * constants.ed2))
     )
@@ -83,7 +82,7 @@ def beta_qcd_as3(nf):
 
 
 @nb.njit(cache=True)
-def beta_qed_aem3(nf):
+def beta_qed_aem3(nf, nl=3):
     r"""Compute the second coefficient of the QED beta function.
 
     Implements Eq. (7) of :cite:`Surguladze:1996hx`.
@@ -101,7 +100,6 @@ def beta_qed_aem3(nf):
     """
     nu = constants.uplike_flavors(nf)
     nd = nf - nu
-    nl = 3  # TODO : pass nl as an argument??
     beta_qed_aem3 = -4.0 * (
         nl + constants.NC * (nu * constants.eu2**2 + nd * constants.ed2**2)
     )
@@ -246,7 +244,7 @@ def beta_qcd(k, nf):
 
 
 @nb.njit(cache=True)
-def beta_qed(k, nf):
+def beta_qed(k, nf, nl=3):
     r"""Compute value of a beta_qed coefficients.
 
     Parameters
@@ -264,9 +262,9 @@ def beta_qed(k, nf):
     """
     beta_ = 0
     if k == (0, 2):
-        beta_ = beta_qed_aem2(nf)
+        beta_ = beta_qed_aem2(nf, nl)
     elif k == (0, 3):
-        beta_ = beta_qed_aem3(nf)
+        beta_ = beta_qed_aem3(nf, nl)
     elif k == (1, 2):
         beta_ = beta_qed_aem2as1(nf)
     else:
@@ -295,7 +293,7 @@ def b_qcd(k, nf):
 
 
 @nb.njit(cache=True)
-def b_qed(k, nf):
+def b_qed(k, nf, nl=3):
     r"""Compute b_qed coefficient.
 
     Parameters
@@ -311,4 +309,4 @@ def b_qed(k, nf):
             b_qed_k(nf)
 
     """
-    return beta_qed(k, nf) / beta_qed((0, 2), nf)
+    return beta_qed(k, nf, nl) / beta_qed((0, 2), nf, nl)
diff --git a/src/eko/constants.py b/src/eko/constants.py
index fbd0df459..c01197405 100644
--- a/src/eko/constants.py
+++ b/src/eko/constants.py
@@ -84,8 +84,6 @@ def uplike_flavors(nf):
     nu : int
 
     """
-    if nf not in range(2, 6 + 1):
-        raise NotImplementedError("Selected nf is not implemented")
     nu = nf // 2
     return nu