Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra entries in drstemplates don't appear in WMO docs... #155

Closed
edwardhartnett opened this issue Oct 25, 2021 · 3 comments · Fixed by #200
Closed

extra entries in drstemplates don't appear in WMO docs... #155

edwardhartnett opened this issue Oct 25, 2021 · 3 comments · Fixed by #200
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@edwardhartnett
Copy link
Contributor

In drstemplates.h we have:

    /** [5.40: Grid point data - JPEG2000 
     * encoding](https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_temp5-40.shtml) */
    { 40, 7, 0, {4,-2,-2,1,1,1,1} },
    
    /** [5.41: Grid point data - PNG 
     * encoding](https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_temp5-41.shtml) */
    { 41, 5, 0, {4,-2,-2,1,1} },
    
    /** 5.40000: Grid point data - JPEG2000 encoding */
    { 40000, 7, 0, {4,-2,-2,1,1,1,1} },
    
    /** 5.40010: Grid point data - PNG encoding */
    { 40010, 5, 0, {4,-2,-2,1,1} }

5.40 and 5.41 are what the WMO docs call JPEG and PNG. They make no mention of 5.40000 and 5.40010. (See https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table5-0.shtml).

So what's going on with 5.40000 and 5.40010? Where did these come from and what are they for? Are they duplicates that can be removed?

@BoiVuong-NOAA or @DusanJovic-NOAA do you know the answer?

@edwardhartnett edwardhartnett added bug Something isn't working question Further information is requested labels Oct 25, 2021
@BoiVuong-NOAA
Copy link
Contributor

No, I do not know the answer. The 5.40000 and 5.40010 were in the code in 2007.

@DusanJovic-NOAA
Copy link
Contributor

I believe these those are local data representation template number. Probably used at NCEP before WMO standardized them. Please check with NCO, maybe there are still some programs using them.

@edwardhartnett
Copy link
Contributor Author

OK, I have added this to the doxygen documention in dretemplates.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants