memory leak in g2_unpack3() if undefined grid template number is used

[edwardhartnett]

There's a test for this (commented out) in tst_unpack.c.

[edwardhartnett]

In the function we have this code:

        /*   Get Grid Definition Template */
        if (!(mapgrid = getgridtemplate(ligds[4])))
        {         /* undefined template */
            ierr = 5;
            return ierr;
        }

But we have already done:

ligds = calloc(5, sizeof(g2int));

So when we exit, we have a memory leak.

[edwardhartnett]

Thing is, ligds is an array of 5 g2int. Really, there's no reason to malloc it, it can just be declared. BUT, in other code, this pointer is later freed. So I will just cause it to be freed in this error condition, so there is no leak.