Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in macos CI run, build PNG from source and cache it instead of getting it from homebrew, then revert to using find_package() in CMake #223

Closed
edwardhartnett opened this issue Nov 12, 2021 · 2 comments · Fixed by #233
Assignees
Labels
build test Testing is important!

Comments

@edwardhartnett
Copy link
Contributor

See #164 (review)

@edwardhartnett edwardhartnett added build test Testing is important! labels Nov 12, 2021
@edwardhartnett edwardhartnett self-assigned this Nov 12, 2021
@edwardhartnett
Copy link
Contributor Author

This should solve #219.

@edwardhartnett edwardhartnett changed the title in macos CI run, build PNG from source and cache it instead of getting it from homebrew, then revert to using find_package() in CMake #222 in macos CI run, build PNG from source and cache it instead of getting it from homebrew, then revert to using find_package() in CMake Dec 7, 2021
@edwardhartnett
Copy link
Contributor Author

The answer that worked was from here: torch/image#137

Basically, there is a libpng that is already installed on macos and is in a /Library/Framework directory which (on MacOS) cmake searches first. So it finds the older version of PNG and gets confused.

The answer is to delete that part of the /Library/Framwork directories like this:
sudo rm -rf /Library/Frameworks/Mono.framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build test Testing is important!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant