From c5d5b2c5ab202f23c8cf103acd09ffbaa92c4045 Mon Sep 17 00:00:00 2001 From: "Ali.Abdolali" <37336972+aliabdolali@users.noreply.github.com> Date: Wed, 17 Mar 2021 21:54:12 -0400 Subject: [PATCH] Create pull_request_template.md (#330) * Create pull_request_template.md --- .github/pull_request_template.md | 43 ++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..006e685d1 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,43 @@ +# Pull Request Summary +(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.) +Please describe the PR summary + +## Description +Provide a detailed description of what this PR does. +What bug does it fix, or what feature does it add? +Is a change of answers expected from this PR? + +### Issue(s) addressed +* Is there an issue associated with this development (bug fix, enhancement, new feature)? +Please add a reference to a related issue(s) in WW3 repository (Follow [link](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue)). +Link the issues to be closed with this PR, whether in this repository, or in another repository. +(Remember, issues should always be created before starting work on a PR branch!). +Note that properly "linked issues" (either automatic links, or manual ones using the correct keywords) will be automatically closed when the PR is merged. + +- fixes # +- fixes noaa-emc/ww3/issues/ + +### Check list +* Is your feature branch up to date with the authoritative repository (NOAA/develop)? +* Make sure you have checked the [checklist for a developer submitting to develop](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-a-developer-submitting-to-develop), [checklist for a developer submitting to develop](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-a-developer-submitting-to-develop) and [updating version number](https://github.com/NOAA-EMC/WW3/wiki/Code-Management#checklist-for-updating-version-number) +* Reviewers: @mentions of suggested reviewers of the proposed changes. + + +### Testing +* How were these changes tested? +* Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) +* If a new feature was added, was a new regression test added? +* Have regression tests been run? +* Which compiler / HPC you used to run the regression tests in the PR? +* Please provide the summary output of matrix.comp (_matrix.Diff.out_, _matrixCompFull.out_ and _matrixCompSummary.out_): +Please indicate the expected changes in the outputs ([excluding the known list of non-identical tests](https://github.com/NOAA-EMC/WW3/wiki/How-to-use-matrix.comp-to-compare-regtests-with-master#4-look-at-results)). + + + + + + + + + +