W3SDB1 - potential return of unitialised values

[ukmo-ccbunney]

There is a test in the Depth Induced Breaking source term (W3SDB1) that returns immediately from the subroutine if there is zero(ish) energy:

WW3/model/src/w3sdb1md.F90

Lines 236 to 240 in 8eb3596

	THR = DBLE(1.E-15)
	IF (SUM(A) .LT. THR) RETURN
	S = 0.
	D = 0.

This is a potential source of uninitialised value errors in the model as S and D (the source and diagonal arrays) are INTENT(OUT) and not initialised prior to the potential return from the function:

WW3/model/src/w3sdb1md.F90

Line 208 in 8eb3596

REAL, INTENT(OUT) :: S(NSPEC), D(NSPEC)

The initisliastion of S and D should be moved above the return statement.

[MatthewMasarik-NOAA]

Very nice find!