Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up jobid definitions in J-jobs #525

Closed
MatthewPyle-NOAA opened this issue Oct 11, 2024 · 5 comments
Closed

clean up jobid definitions in J-jobs #525

MatthewPyle-NOAA opened this issue Oct 11, 2024 · 5 comments
Assignees
@BenjaminBlake-NOAA
Labels
EE2-specific Focused on improving EE2 compliance

Comments

@MatthewPyle-NOAA
Copy link
Contributor

jobid/taskid defining has yet to be done consistently throughout the system. This issue is to remind us to consistently apply a solution for all J-jobs.
@MatthewPyle-NOAA MatthewPyle-NOAA added the EE2-specific Focused on improving EE2 compliance label Oct 11, 2024
@MatthewPyle-NOAA MatthewPyle-NOAA mentioned this issue Oct 11, 2024
Merged
1 task
@hu5970
Copy link
Contributor

hu5970 commented Oct 11, 2024

@BenjaminBlake-NOAA Thanks for working on this. I will run test after your make your PR.

@BenjaminBlake-NOAA
Copy link
Contributor

@hu5970 Thank you, that sounds good to me. I should have a PR ready later today or tomorrow.

@BenjaminBlake-NOAA BenjaminBlake-NOAA mentioned this issue Oct 18, 2024
Merged
17 tasks
@BenjaminBlake-NOAA
Copy link
Contributor

@hu5970 I just created a draft PR with these changes here: #535
Are you still able to help with testing? I ran a quick DA engineering test and it completed successfully.

@MatthewPyle-NOAA
Copy link
Contributor Author

@BenjaminBlake-NOAA can this issue be closed now?

@BenjaminBlake-NOAA
Copy link
Contributor

@MatthewPyle-NOAA Yes I think so.

@github-project-automation github-project-automation bot moved this from In progress to Done in rrfs-workflow-1.1.0 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminBlake-NOAA BenjaminBlake-NOAA

Labels
EE2-specific Focused on improving EE2 compliance
Projects
rrfs-workflow-1.1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hu5970 @MatthewPyle-NOAA @BenjaminBlake-NOAA