Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peformance degradation between 2023.04 and current main #1444

Closed
uramirez8707 opened this issue Jan 18, 2024 · 3 comments · Fixed by #1445
Closed

Peformance degradation between 2023.04 and current main #1444

uramirez8707 opened this issue Jan 18, 2024 · 3 comments · Fixed by #1445

Comments

@uramirez8707
Copy link
Contributor

Describe the bug

There is a small performance degradation between 2023.04 and the 2024.01-alpha2.
For example, for ESM4.2, Main loop clocks are almost the same between 2024.01-alpha2 and 2023.04. The Initialization clock has increased a bit from 96secs to 125secs.

This is related to #1388. nearest_index is a bit slower than the indp (this was used in horiz_interp in 2023.04). Particularly the part of the code that checks that the array passed in is monotonically increasing/decreasing is not very efficient

To Reproduce
Compare initialization times between 2023.04 and 2024.01-alpha2.

Expected behavior
Performance of FMS should be as best as possible.

System Environment
Describe the system environment, include:
This happens in any system, but I saw this in the amd box with the data_override unit tests and in GAEA.

Additional context
N/A

@uramirez8707
Copy link
Contributor Author

closed in #1445

@thomas-robinson
Copy link
Member

@uramirez8707 Do we need to reopen the original issue?

@uramirez8707
Copy link
Contributor Author

No this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants