Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fv3atm needs the global_tile from atmosphere_control_data so CCPP can read per-tile static files #329

Closed
SamuelTrahanNOAA opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SamuelTrahanNOAA
Copy link

Is your feature request related to a problem? Please describe.
Additional information is here:

NOAA-EMC/fv3atm#797

In the fv3atm, some CCPP physics schemes read per-tile static files. With a global simulation that has a single static nest (tile 7) the nest will read tile 1, which is the first global tile. This is because the model is using tile_of_mosaic instead of global_tile.

Describe the solution you'd like
The atmosphere_control_data should be able to provide the global_tile.

Suggested Solution

In addition to relevant model-level changes:

diff --git a/driver/fvGFS/atmosphere.F90 b/driver/fvGFS/atmosphere.F90
index dcd43fb..a718b95 100644
--- a/driver/fvGFS/atmosphere.F90
+++ b/driver/fvGFS/atmosphere.F90
@@ -864,17 +864,18 @@ contains
  end subroutine atmosphere_pref
 
 
- subroutine atmosphere_control_data (i1, i2, j1, j2, kt, p_hydro, hydro, tile_num)
+ subroutine atmosphere_control_data (i1, i2, j1, j2, kt, p_hydro, hydro, tile_of_mosaic, global_tile_num)
    integer, intent(out)           :: i1, i2, j1, j2, kt
    logical, intent(out), optional :: p_hydro, hydro
-   integer, intent(out), optional :: tile_num
+   integer, intent(out), optional :: tile_of_mosaic, global_tile_num
    i1 = Atm(mygrid)%bd%isc
    i2 = Atm(mygrid)%bd%iec
    j1 = Atm(mygrid)%bd%jsc
    j2 = Atm(mygrid)%bd%jec
    kt = Atm(mygrid)%npz
 
-   if (present(tile_num)) tile_num = Atm(mygrid)%tile_of_mosaic
+   if (present(global_tile_num)) global_tile_num = Atm(mygrid)%global_tile
+   if (present(tile_of_mosaic)) tile_of_mosaic = Atm(mygrid)%tile_of_mosaic
    if (present(p_hydro)) p_hydro   = Atm(mygrid)%flagstruct%phys_hydrostatic
    if (present(  hydro))   hydro   = Atm(mygrid)%flagstruct%hydrostatic

Describe alternatives you've considered
Can't think of any.

Additional context
This is for the Water in the West project, which aims to have a static nest over the north-east pacific within a global model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants