[REFACTOR] MVVM 리팩토링 (#7) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FpRaArNkK
approved these changes
Jun 21, 2024
Comment on lines
+12
to
+27
| static func calculateDate() -> String { | ||
| let today = Date() | ||
| let calendar = Calendar.current | ||
| var dateComponents = DateComponents() | ||
| dateComponents.day = -1 | ||
|
|
||
| if let oneDayAgo = calendar.date(byAdding: dateComponents, to: today) { | ||
| let dateFormatter = DateFormatter() | ||
| dateFormatter.dateFormat = "yyyyMMdd" | ||
|
|
||
| let oneDayAgoString = dateFormatter.string(from: oneDayAgo) | ||
| return oneDayAgoString | ||
| } else { | ||
| return "" | ||
| } | ||
| } |
There was a problem hiding this comment.
let yesterday = calendar.date(byAdding: .day, value: -1, to: Date())
이런 방법도 있답니다!
추후 범용성을 생각한다면 매개변수로 calculate할 Int 값을 받아 value로 넣어줘도 좋을 것 같아요!
Comment on lines
+10
to
+28
| final class ObservablePattern<T> { // --- a | ||
|
|
||
| var value: T? { // --- b | ||
| didSet { | ||
| self.listener?(value) | ||
| } | ||
| } | ||
|
|
||
| init(_ value: T?) { | ||
| self.value = value | ||
| } | ||
|
|
||
| private var listener: ((T?) -> Void)? // --- c | ||
|
|
||
| func bind(_ listener: @escaping (T?) -> Void) { | ||
| listener(value) // 생략 가능, 여기선 시작되는 순간부터 초기값을 갖고 동작하기 위해 사용 | ||
| self.listener = listener | ||
| } | ||
| } |
There was a problem hiding this comment.
ViewModel에서 관리하는 비즈니스 로직은 UI 조작부분을 제외하고 잡으신 것 같아요!
MVVM 리팩토링에서 너무 좋은 방법인 것 같습니다 bbb
Comment on lines
+36
to
+38
| var nickname: String? = nil | ||
|
|
||
| private let loginViewModel: LoginViewModel = LoginViewModel() |
Comment on lines
+168
to
+190
| func setViewModel() { | ||
| mainViewModel.didUpdateNetworkResult.bind { [weak self] isSuccess in | ||
| guard let isSuccess else { return } | ||
| if isSuccess { | ||
| self?.mainCollectionView.reloadData() | ||
| } | ||
| } | ||
|
|
||
| mainViewModel.didChangeLoadingIndicator.bind { [weak self] isLoading in | ||
| guard let isLoading else { return } | ||
| if isLoading { | ||
| self?.loadingIndicator.startAnimating() | ||
| } else { | ||
| self?.loadingIndicator.stopAnimating() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func getMovieInfo() { | ||
| if mainViewModel.getMovieInfo() { | ||
| self.mainCollectionView.reloadData() | ||
| } | ||
| } |
There was a problem hiding this comment.
ViewModel의 Stream Subscribe 로직들 너무 좋은 것 같습니다! bb
There was a problem hiding this comment.
ViewModel에서 Delegate 처리해주는 게 너무 좋습니다 bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
🚨 참고 사항
1. UICollectionViewDataSource는 어디서 처리할까
📟 관련 이슈