Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect logic in collection? #56

Closed
bnb32 opened this issue Mar 10, 2023 · 0 comments · Fixed by #57
Closed

incorrect logic in collection? #56

bnb32 opened this issue Mar 10, 2023 · 0 comments · Fixed by #57

Comments

@bnb32
Copy link
Collaborator

bnb32 commented Mar 10, 2023 •
edited
Loading

https://github.com/NREL/nsrdb/blob/36e9af32b61919573c4e98aff7e440920a85cf7b/nsrdb/file_handlers/collection.py#L168:L183

Malik discovered an edge case here (same code in sup3r): If row_loc or col_loc is [0] then not any() will be True even though a location was found. Should we change the not any() to not len() > 0?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

edge case fix for collection - get_slices NREL/nsrdb
1 participant
@bnb32