Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compilation error with MATX_ENABLE_CUTLASS in transforms/matmul.h #605

Closed
bk8190 opened this issue Apr 10, 2024 · 3 comments · Fixed by #610
Closed

[BUG] Compilation error with MATX_ENABLE_CUTLASS in transforms/matmul.h #605

bk8190 opened this issue Apr 10, 2024 · 3 comments · Fixed by #610

Comments

@bk8190
Copy link

bk8190 commented Apr 10, 2024

Describe the Bug
Compilation error in MatX/include/matx/transforms/matmul.h when building with MATX_EN_CUTLASS=on

Regression seems to have be introduced by d75d702
The commit replaces "idx" with "a_idx" "b_idx" and "c_idx". The variable "idx" likely needs to be updated in the #if MATX_ENABLE_CUTLASS block starting on line 948

@cliffburdick
Copy link
Collaborator

Hi @bk8190 , we were not aware of anyone using the cutlass interface since it's untested. We will take a look and make sure it compiles. Can I ask why you're using this over the default cublas interface?

@bk8190
Copy link
Author

bk8190 commented Apr 10, 2024

Hi @cliffburdick - I am experimenting with the library and saw the option in the main CMakeLists.txt so I figured I would give it a try, but if it's untested I will stay clear

@cliffburdick
Copy link
Collaborator

@bk8190 it was working several months back, but because of the compile times it was taking far too long to test. We had to put it on hold in favor of cuBLAS because of the compile times. CUTLASS does have a few more capabilities that cuBLAS did not have at the time, like non-affine indexing, but the compile times were ultimately not something we could deal with for now. If you have a reason to use it over cuBLAS please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants