stats: remove "cold-read-write" metric (obsolete)

* transitioned to using per-backend "total" latencies * up cli Signed-off-by: Alex Aizman <[email protected]>
NVIDIA · Jul 23, 2024 · c8c187e · c8c187e
1 parent 988051c
commit c8c187e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 16 deletions.
diff --git a/ais/tgtimpl.go b/ais/tgtimpl.go
@@ -197,11 +197,9 @@ func (t *target) GetCold(ctx context.Context, lom *core.LOM, owt cmn.OWT) (ecode
 }
 
 func (t *target) coldstats(backend core.Backend, size, started int64) {
-	delta := mono.SinceNano(started)
 	t.statsT.AddMany(
 		cos.NamedVal64{Name: backend.MetricName(stats.GetCount), Value: 1},
-		cos.NamedVal64{Name: stats.GetColdRwLatency, Value: delta},
-		cos.NamedVal64{Name: backend.MetricName(stats.GetLatencyTotal), Value: delta},
+		cos.NamedVal64{Name: backend.MetricName(stats.GetLatencyTotal), Value: mono.SinceNano(started)},
 		cos.NamedVal64{Name: backend.MetricName(stats.GetSize), Value: size},
 	)
 }

diff --git a/ais/tgtobj.go b/ais/tgtobj.go
@@ -1190,8 +1190,8 @@ func (goi *getOI) stats(written int64) {
 		cos.NamedVal64{Name: stats.GetCount, Value: 1},
 		cos.NamedVal64{Name: stats.GetSize, Value: written},
 		cos.NamedVal64{Name: stats.GetThroughput, Value: written}, // vis-à-vis user (as written m.b. range)
-		cos.NamedVal64{Name: stats.GetLatency, Value: delta},      // see also: stats.GetColdRwLatency
-		cos.NamedVal64{Name: stats.GetLatencyTotal, Value: delta}, // see also: stats.GetColdRwLatency
+		cos.NamedVal64{Name: stats.GetLatency, Value: delta},      // see also: per-backend *LatencyTotal below
+		cos.NamedVal64{Name: stats.GetLatencyTotal, Value: delta}, // ditto
 	)
 	if goi.verchanged {
 		goi.t.statsT.AddMany(
@@ -1202,11 +1202,9 @@ func (goi *getOI) stats(written int64) {
 
 	if goi.rltime > 0 {
 		bck := goi.lom.Bck()
-		debug.Assert(bck.IsRemote())
 		backend := goi.t.Backend(bck)
 		goi.t.statsT.AddMany(
 			cos.NamedVal64{Name: backend.MetricName(stats.GetCount), Value: 1},
-			cos.NamedVal64{Name: stats.GetColdRwLatency, Value: goi.rltime},
 			cos.NamedVal64{Name: backend.MetricName(stats.GetE2ELatencyTotal), Value: delta},
 			cos.NamedVal64{Name: backend.MetricName(stats.GetLatencyTotal), Value: goi.rltime},
 			cos.NamedVal64{Name: backend.MetricName(stats.GetSize), Value: written},

diff --git a/cmd/cli/go.mod b/cmd/cli/go.mod
@@ -3,7 +3,7 @@ module github.com/NVIDIA/aistore/cmd/cli
 go 1.22.3
 
 require (
-	github.com/NVIDIA/aistore v1.3.24-0.20240722230742-1c3f24573b25
+	github.com/NVIDIA/aistore v1.3.24-0.20240723174026-988051c282df
 	github.com/fatih/color v1.17.0
 	github.com/json-iterator/go v1.1.12
 	github.com/onsi/ginkgo/v2 v2.19.0

diff --git a/cmd/cli/go.sum b/cmd/cli/go.sum
@@ -1,7 +1,7 @@
 code.cloudfoundry.org/bytefmt v0.0.0-20190710193110-1eb035ffe2b6/go.mod h1:wN/zk7mhREp/oviagqUXY3EwuHhWyOvAdsn5Y4CzOrc=
 github.com/BurntSushi/toml v1.3.2/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
-github.com/NVIDIA/aistore v1.3.24-0.20240722230742-1c3f24573b25 h1:RYiPcXgY4/TzqMi+JfMqVwdfpqMVpjq92E6rodTWpvU=
-github.com/NVIDIA/aistore v1.3.24-0.20240722230742-1c3f24573b25/go.mod h1:A4wCIW7GooZSzDxTxh4pS092Ve9gCiXh1EvtjlVB8ew=
+github.com/NVIDIA/aistore v1.3.24-0.20240723174026-988051c282df h1:QMtEJPwucvzOQbv7gLrZ5xttZVKB3AQ3e+ZHJt6/aY4=
+github.com/NVIDIA/aistore v1.3.24-0.20240723174026-988051c282df/go.mod h1:A4wCIW7GooZSzDxTxh4pS092Ve9gCiXh1EvtjlVB8ew=
 github.com/OneOfOne/xxhash v1.2.8 h1:31czK/TI9sNkxIKfaUfGlU47BAxQ0ztGgd9vPyqimf8=
 github.com/OneOfOne/xxhash v1.2.8/go.mod h1:eZbhyaAYD41SGSSsnmcpxVoRiQ/MPUTjUdIIOT9Um7Q=
 github.com/VividCortex/ewma v1.1.1/go.mod h1:2Tkkvm3sRDVXaiyucHiACn4cqf7DpdyLvmxzcbUokwA=

diff --git a/stats/target_stats.go b/stats/target_stats.go
@@ -61,10 +61,6 @@ const (
 	PutRedirLatency    = "put.redir.ns"
 	DownloadLatency    = "dl.ns"
 
-	// (read remote, write local) latency (and note that cold-GET's "pure"
-	// transmit-response latency = GetLatency - GetColdRwLatency)
-	GetColdRwLatency = "get.cold.rw.ns"
-
 	// Dsort
 	DsortCreationReqCount    = "dsort.creation.req.n"
 	DsortCreationRespCount   = "dsort.creation.resp.n"
@@ -218,8 +214,6 @@ func (r *Trunner) RegMetrics(snode *meta.Snode) {
 	r.reg(snode, GetRedirLatency, KindLatency)
 	r.reg(snode, PutRedirLatency, KindLatency)
 
-	r.reg(snode, GetColdRwLatency, KindLatency) // + backend metrics (see ais/backend/common)
-
 	// bps
 	r.reg(snode, GetThroughput, KindThroughput)
 	r.reg(snode, PutThroughput, KindThroughput)