Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thrust universal_host_pinned_memory_resource's pointer type should probably be a universal_ptr #2659

Open
Tracked by #101
bernhardmgruber opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working right. thrust For all items related to Thrust.

Comments

@bernhardmgruber
Copy link
Contributor

bernhardmgruber commented Oct 30, 2024

We have the alias universal_host_pinned_memory_resource in each system with a comment that it is an alias to universal_memory_resource, which is a lie. IMO, universal_host_pinned_memory_resource should be an alias to universal_memory_resource except for the CUDA system. The current state is inconsistent, because the pointer type of universal_host_pinned_memory_resource is a native pointer and a not a universal_ptr<T>, like for universal_memory_resource. Fixing this is technically a breaking change.

We should address this in the next major release.

Originally posted by @bernhardmgruber in #2653 (comment)

@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 30, 2024
@bernhardmgruber bernhardmgruber added thrust For all items related to Thrust. bug Something isn't working right. labels Oct 30, 2024
@bdice bdice changed the title Thrust universal_host_pinned_memory_resource's pointer type should probably be a universial_ptr Thrust universal_host_pinned_memory_resource's pointer type should probably be a universal_ptr Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. thrust For all items related to Thrust.
Projects
Status: Todo
Development

No branches or pull requests

1 participant