Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support pair_contains_if in static_map and static_multimap #176

Closed
ttnghia opened this issue Jun 15, 2022 · 1 comment
Closed

[FEA] Support pair_contains_if in static_map and static_multimap #176

ttnghia opened this issue Jun 15, 2022 · 1 comment
Labels
helps: rapids Helps or needed by RAPIDS topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request wontfix This will not be worked on

Comments

@ttnghia
Copy link

ttnghia commented Jun 15, 2022

Once we have pair_contains (#173), we also need to have pair_contains_if so we can avoid checking contains for the elements that we already knew the result for them. By doing so, we will not perform unnecessarily expensive computations.
This was referenced Jun 15, 2022
Merged
Merged
Closed
@PointKernel PointKernel added type: feature request New feature request topic: static_map Issue related to the static_map helps: rapids Helps or needed by RAPIDS P1: Should have Necessary but not critical topic: static_multimap Issue related to the static_multimap labels Jun 15, 2022
@PointKernel PointKernel mentioned this issue Jun 21, 2022
Closed
@PointKernel PointKernel added wontfix This will not be worked on and removed P1: Should have Necessary but not critical labels Jul 25, 2022
@PointKernel
Copy link
Member

Closing this since the functionality is no longer desired by using set contains_if.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
helps: rapids Helps or needed by RAPIDS topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttnghia @PointKernel