Allocator takes no stream argument #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does libcudf need to be updated for this change? |
Yes, will make the cudf PR tomorrow. |
robertmaynard
approved these changes
Nov 17, 2021
|
@jrhemstad can you please review this PR whenever you have time? |
jrhemstad
approved these changes
Dec 2, 2021
jrhemstad
approved these changes
Dec 2, 2021
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Dec 6, 2021
Depends on NVIDIA/cuCollections#119 This PR replaces the default hash join allocator with the corresponding `rmm::mr::stream_allocator_adaptor`. It accommodates new `cuco::allocator` APIs that don't take stream as input argument. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - Karthikeyan (https://github.com/karthikeyann) - Mark Harris (https://github.com/harrism) URL: #9704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when users pass an allocator taking no stream argument. It removes
stream_member variable incuco::static_multimapsince it's no longer required in ctor/dtor.