Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doxygen check with unsupported version. #344

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 2, 2023

While running pre-commit, I got this error:

./ci/checks/doxygen.sh: line 19: : command not found
./ci/checks/doxygen.sh: line 20: : command not found
./ci/checks/doxygen.sh: line 21: : command not found

I have doxygen 1.9.7 installed, which isn't a supported version in this script. The Doxygen check is supposed to pass silently when run locally with an unsupported version (it runs properly in CI, instead).

It seems like there's an unrecognized symbol in the bash script from PR #177: 05fb1db

This PR removes that symbol, fixing the error.

@PointKernel PointKernel added the type: docs Improvements or additions to documentation label Aug 2, 2023
@PointKernel PointKernel merged commit 3d577bf into NVIDIA:dev Aug 2, 2023
@bdice
Copy link
Contributor Author

bdice commented Aug 2, 2023

@PointKernel Does CI need to pass before a PR is merged? This is still running GPU tests. I don't expect a failure, just wasn't sure if CI was supposed to be required or not.

@PointKernel
Copy link
Member

Does CI need to pass before a PR is merged?

For actual cpp/CUDA changes, I would wait for CI to complete before merging the PR. This work only touches the doxygen file and our style checks passed already thus the remaining cpp tests are not mandatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants