Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

[RFE] Add merge sort support #283

Closed
zasdfgbnm opened this issue Apr 9, 2021 · 1 comment · Fixed by #322
Closed

[RFE] Add merge sort support #283

zasdfgbnm opened this issue Apr 9, 2021 · 1 comment · Fixed by #322
Labels
type: enhancement New feature or request.

Comments

@zasdfgbnm
Copy link
Contributor

We are migrating thrust::sort to cub::DeviceRadixSort in PyTorch. We observe that, for small problem sizes, merge sort in thrust is much faster than cub's radix sort. See, for example, pytorch/pytorch#55693

I suggest adding merge sort as a feature of cub, so that we can choose which sort to use.
@alliepiper alliepiper added this to the Backlog milestone Apr 12, 2021
@alliepiper alliepiper added the type: enhancement New feature or request. label Apr 12, 2021
@alliepiper
Copy link
Collaborator

This has been on my todo-list for a while.

Once we start expanding CUB's device algorithm library, merge sort will be among the first to be added.

@alliepiper alliepiper linked a pull request Jun 15, 2021 that will close this issue
Add CUB block and device merge sort #322
Merged
@alliepiper alliepiper removed this from the Backlog milestone Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CUB block and device merge sort gevtushenko/cub
2 participants
@alliepiper @zasdfgbnm