This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Update scan deduced types to be standards-compliant. #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
requested review from
brycelelbach,
griwes,
jaredhoberock and
dkolsen-pgi
dkolsen-pgi
reviewed
May 29, 2020
dkolsen-pgi
approved these changes
May 29, 2020
|
Internal CL: 28484173 |
alliepiper
added
testing: internal ci in progress
|
Make sure to note in the commit message that this is a breaking change so that I will include it in the breaking changes section of the changelog for the next release. |
brycelelbach
approved these changes
Jun 3, 2020
alliepiper
removed
testing: internal ci in progress
TBB's scan was implemented differently than the other backends, leading to some failing unit tests. This patch fixes these inconsistencies by making the following changes: - Follow P0571's guidance regarding accumulator variable type. - https://wg21.link/P0571 - The accumulator's type is now: - The type of the user-supplied initial value (if provided), or - The input iterator's value type if no initial value. - Follow C++ standard guidance for default binary operator type. - https://eel.is/c++draft/exclusive.scan#1 - Thrust binary/unary functors now specialize a default void template parameter. Types are deduced and forwarded transparently. - Updated the scan's default binary operator to the new `thrust::plus<>` specialization. - The `intermediate_type_from_function_and_iterators` helper is no longer needed and has been removed. Closes NVIDIA#1170.
alliepiper
force-pushed
the
bug/github/scan_edgecases/1170
branch
from
83eff97 to
b30a856
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heads up that this patch changes the output of scan algorithms under certain edge cases. See the updated unit test for examples.
TBB's scan was implemented differently than the other backends, leading
to some failing unit tests.
This patch fixes these inconsistencies by making the following changes:
parameter. Types are deduced and forwarded transparently.
thrust::plus<>specialization.intermediate_type_from_function_and_iteratorshelper is nolonger needed and has been removed.
Closes #1170.