Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate to_vector functionality #99

Open
jwaldrop107 opened this issue Jul 19, 2022 · 0 comments
Open

Consolidate to_vector functionality #99

jwaldrop107 opened this issue Jul 19, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jwaldrop107
Copy link
Member

There are currently two different functions that more or less convert a TensorWrapper to a std::vector<double>. to_vector_from_pimpl lives in src/tensorwrapper/tensor/detail_/pimpl.cpp, and to_vector is in include/tensorwrapper/tensor/conversions.hpp. These two should be consolidated into a single function.
@jwaldrop107 jwaldrop107 added the good first issue Good for newcomers label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwaldrop107