Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the caller decide which format(s) to export #5

Open
maddy2101 opened this issue Oct 7, 2018 · 1 comment
Open

Let the caller decide which format(s) to export #5

maddy2101 opened this issue Oct 7, 2018 · 1 comment

Comments

@maddy2101
Copy link

Currently all available exporters are put to action if the executable is called. I'd like to specify which format I want to export.

Feel free to assign this to me, I can provide a PR, but it would introduce symfony/console as a dependency.

@NamelessCoder
Copy link
Owner

I like this idea, but the way I see the dependency architecture it makes more sense with packages that provide various additions - for example, smoother ways to use the CLI or additional exporters. Taking the RST generator and Symfony CLI ideas, those would in my mind be two different packages:

  • xyz/fluid-documentation-generator-rst which adds a new exporter
  • xyz/fluid-documentation-generator-cli which provides a Symfony base for commands

If/when the latter package was created I would have no worries adding it to suggests and removing the native dumb-style CLI from this package. I would love to not have any CLI capability in this package itself, so it can focus 100% on providing a nice extensible API for the generating engine itself. The end goal being to not make such decisions for people integrating it, but allowing them to pick any number of user-interface-level packages to run the engine.

How does this sound to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants