Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

sprysphere.com #3231

Closed
NanoMeow opened this issue Mar 6, 2020 · 6 comments
Closed

sprysphere.com #3231

NanoMeow opened this issue Mar 6, 2020 · 6 comments
Labels
f: archived This issue was archived, submit new reports for new problems with this website. f: resolved This issue was resolved. t: ads This issue was classified as missed ads. This includes ads, popups, and ads timers.

Comments

@NanoMeow
Copy link
Owner

NanoMeow commented Mar 6, 2020

Basic Information

Test link: http://sprysphere.com/BiZZ
Category: other
Reported from: Canada
Template version: 2

User Environment

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/80.0.3987.87 Chrome/80.0.3987.87 Safari/537.36
Extension: Nano Adblocker 1.0.0.140

Additional Message

See: https://gitlab.com/xuhaiyang1234/NanoAdblockerSecretIssues/issues/12#note_300130822

@NanoMeow NanoMeow added the s: untriaged This issue has not been triaged yet. label Mar 6, 2020
@jspenguin2017 jspenguin2017 changed the title gitlab.com sprysphere.com Mar 6, 2020
@jspenguin2017 jspenguin2017 self-assigned this Mar 6, 2020
@jspenguin2017
Copy link
Collaborator

@lain566 said on Mar 5, 2020:

I know this has nothing to do with [redacted], but, Does this commit fix adfly notifications?
https://github.com/jspenguin2017/uBlockProtector/commit/591c8769b6fa4a68cbc85b34633372da930774e8

I just tried and I'm still stuck, however I tried the Adguard scriptlet they got from uBO and it works fine
https://github.com/AdguardTeam/Scriptlets/blob/master/src/scriptlets/prevent-adfly.js

I tried it with this link
http://sprysphere.com/BiZZ and I was immediately redirected to dropbox.com

What's the difference between the two?

@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented Mar 7, 2020

@lain566

The change is to address jspenguin2017/uBlockProtector#1104 , it has nothing to do with the issue related to notification popups.

I checked AdGuard's code, it is based on uAssets' code which is in turn based on ND's code. I don't believe anyone made any meaningful changes to the code for almost a year, so there isn't really any major differences between the current AdGuard's code and the current ND's code.

I tried to change ND's code to exactly match AdGuard's code, but I still get the notification popup, so I think AdGuard is bypassing the notification in some other ways.

@jspenguin2017 jspenguin2017 added s: backlog This issue is on the backlog. s: dispatched This issue was dispatched. Awaiting maintainers to respond. t: ads This issue was classified as missed ads. This includes ads, popups, and ads timers. and removed s: untriaged This issue has not been triaged yet. labels Mar 7, 2020
@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented Mar 7, 2020

Merging this into the existing issue in Nano Filters repository.

See: NanoAdblocker/NanoFilters#370

@lain566
Copy link

lain566 commented Mar 7, 2020

@jspenguin2017 Thanks for checking, this confirms my doubts, so, I have done a little research, and yes, I know what is the filter that makes the redirection immediate, are two filters.
I have added an exception to disable those filters, and the result is the same as with uBO.

I already knew those filters, but I didn't care, because at that time I had no problems with redirection, and I couldn't reproduce this issue.

So, if you have opened this issue, for my question in gitlab, then this issue can be closed and marked as Resolved, you are the right person to answer this type of question, after all the script code is yours from the beginning and your answer has cleared my doubts, and as I see many open issues on this topic, if you want we can continue the discussion here NanoAdblocker/NanoFilters#370 for example.

@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented Mar 7, 2020

Yes, please continue the discussion in NanoAdblocker/NanoFilters#370 . This issue will be left open to not confuse bots.

@jspenguin2017 jspenguin2017 added f: resolved This issue was resolved. and removed s: backlog This issue is on the backlog. s: dispatched This issue was dispatched. Awaiting maintainers to respond. labels Mar 8, 2020
@jspenguin2017
Copy link
Collaborator

Fix available in the next version of ND.

@github-actions github-actions bot added the f: archived This issue was archived, submit new reports for new problems with this website. label Aug 24, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: archived This issue was archived, submit new reports for new problems with this website. f: resolved This issue was resolved. t: ads This issue was classified as missed ads. This includes ads, popups, and ads timers.
Projects
None yet
Development

No branches or pull requests

3 participants