You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar in nature to #799, it might make sense to postpone fixing this issue in next major Skosmos version as the globally declared variables are probably used in plenty of plugins, thus, being a backwards incompatible fix.
Similarly, there could be a guideline for Skosmos plugings to register them under, for example, SKOSMOS.plugings or similar.
At the moment Skosmos "leaks" JS variables into global namespace (see https://github.com/NatLibFi/Skosmos/blob/master/view/scripts.twig for a more detailed information) which causes global namespace pollution.
Similar in nature to #799, it might make sense to postpone fixing this issue in next major Skosmos version as the globally declared variables are probably used in plenty of plugins, thus, being a backwards incompatible fix.
Similarly, there could be a guideline for Skosmos plugings to register them under, for example, SKOSMOS.plugings or similar.
Any comments @osma @joelit ?
The text was updated successfully, but these errors were encountered: