Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality: Organize JS variables into a single SKOSMOS variable instead of global population #1090

Closed
kouralex opened this issue Oct 28, 2020 · 1 comment

Comments

@kouralex
Copy link
Contributor

At the moment Skosmos "leaks" JS variables into global namespace (see https://github.com/NatLibFi/Skosmos/blob/master/view/scripts.twig for a more detailed information) which causes global namespace pollution.

Similar in nature to #799, it might make sense to postpone fixing this issue in next major Skosmos version as the globally declared variables are probably used in plenty of plugins, thus, being a backwards incompatible fix.

Similarly, there could be a guideline for Skosmos plugings to register them under, for example, SKOSMOS.plugings or similar.

Any comments @osma @joelit ?

@kouralex kouralex added this to the Next Tasks milestone Oct 28, 2020
@osma osma modified the milestones: Next Tasks, 3.0 Oct 10, 2022
@osma
Copy link
Member

osma commented May 16, 2023

This was implemented in PR #1438.

@osma osma closed this as completed May 16, 2023
@joelit joelit moved this to Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR) in Skosmos 3.0 Backlog Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

No branches or pull requests

2 participants